refactor ssh client handling#24
Open
clive-jevons wants to merge 1 commit into
Open
Conversation
in order to be able to provide different approaches to how the SSH client is handled, as a first step refactor the management of the ssh clients created into its own interface - in a second step we can then provide different implementations via new impls of the interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to be able to provide different approaches to how the SSH client is handled, as a first step refactor the management of the ssh clients created into its own interface - in a second step we can then provide different implementations via new impls of the interface
so as to maintain backwards compatibility the code uses some "provider" style types / funcs here and there so that if the user of the library changes any of the public facing members after creation, the runtime code will pick up those changes
also did a small refactoring of the logging so that it can be reused between the ssh tunnel itself and the new ssh client manager.
This change is