fix stale SSH connections on server#23
Open
clive-jevons wants to merge 1 commit into
Open
Conversation
we are using the sshtunnel library for a cli tool for operations and noticed that we were ending up with many stale ssh connections being held on our remote hosts. This PR changes a few things - we only keep one SSH client open, each local/remote pair is closed when copying stops between them, the cleanup is made to accomodate the new setup
Owner
|
I'm hesitant to accept this considering how it might change the backwards compatibility. I would suggest adding an option to SSHTunnel so it can be enabled. |
Author
|
@elliotchance <- I've created #24 in order to pull out the ssh client management in a first step, and if it looks good to you and we can merge that then I'd rework this PR on top of that PR to provide a parallel implementation which can be activated by a feature flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the sshtunnel library for a cli tool for operations and noticed that we were ending up with many stale ssh connections being held on our remote hosts.
This PR changes a few things
This change is