[V2:11] Add Serve Runtime#25
Open
ritorhymes wants to merge 8 commits into
Open
Conversation
This was referenced May 5, 2026
776a559 to
f5d4238
Compare
f5d4238 to
fcfad99
Compare
Add workspace-local `.build-eips.toml` loading and starter configuration. Introduce `config::ActiveRepo` to load the selected checkout’s `Build.toml`, validate explicit `-C` roots, and expose active repository context to later commands. Keep source materialization, initialization, and diagnostics in their owning later branches.
Add clean and dirty source materialization for the active repository and sibling content. Use `config::RepositoryUse` throughout the runtime path, preserve tracked working-tree materialization and `index_path`, and reject dirty active manifests in clean modes. Build, check, and serve prepare sources without fetching the active upstream; `changed` retains upstream fetching for comparison.
Add workspace initialization from the selected active `Build.toml`. Clone missing sibling repositories from declared locations and initialize a missing theme checkout from the manifest repository and pin. Preserve existing usable checkouts and fail without deleting unusable paths. Write `.build-eips.toml` only when absent and generate `WORKSPACE.md` for the initialized workspace.
Add `build-eips doctor` for validating workspace configuration, active `Build.toml`, managed sibling repositories, the local theme checkout, and required tools. Report ok/warn/fail diagnostics; invalid active manifests and unusable theme configuration fail, while expected sibling and theme-pin conditions can warn. Keep diagnostics read-only and leave execution and runtime behavior to later branches.
Resolve build, check, and serve source policy around local active sources, clean mode, remote siblings, build roots, and base URL precedence. Keep `--clean` and `--remote-siblings` as source controls and limit `--only` to supported local dirty modes. Route runtime commands through one resolved execution policy.
Run Zola with the editable `workspace/theme` checkout. Materialize tracked local theme files into prepared `themes/eips-theme`, load Zola and eipw configuration from that local checkout, and keep runtime commands independent of manifest network access.
Add prepared runtime build pipeline. Materialize active and sibling sources according to resolved execution policy, preprocess merged proposal content, prepare the local theme mount, and invoke runtime checks and rendering from `pipeline.rs`. Keep serve watch and sync behavior in the serve runtime branch.
Add server binding resolution and serve-only host/port flags for local Zola serve commands. Run Zola serve with the resolved server binding, optional base URL override, fast/force serve flags, and generated output directory. Add dirty serve watching for dirty active-repo paths and local theme changes. Clean mode disables active-repo sync but keeps theme sync.
fcfad99 to
53015fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the V2
serveruntime on top of the prepared pipeline, adding serve-specific server binding and live synchronization while Zola is running.serveaccepts--host/--port, consumes the resolved--base-urlfrom V2:08, passes binding/output args to Zola, and runs a watcher that syncs dirty active-repo paths into the materialized repo (rerunning markdown preprocessing) and tracked local-theme changes intorepo/themes/eips-theme;--cleandisables the active-repo half but leaves theme sync on. It does not add targetedserve --only, so review should focus on server-binding precedence, Zola serve args, the two-target watcher behavior, and markdown reprocessing on active-source change.--hostand--portCLI flags.[server]config, or defaults.--fast,--force,--interface,--port, and generated output args.serve.rsfor dirty active-repo and local-theme synchronization while Zola is running.notifydependency and serve/runtime tests.Review Notes
This PR completes the serve runtime on top of the prepared pipeline from V2:10. Earlier PRs establish execution policy and prepared inputs; this PR makes
Prepared::servemanage live synchronization and pass serve-specific settings to Zola.Server binding is resolved centrally in execution policy. CLI
--host/--portvalues override workspace[server]settings, which fall back to the default127.0.0.1:1111binding from the workspace config schema.--base-urlwas accepted and resolved for serve in V2:08. This PR is where Zola serve consumes it, adding-u <base-url>and--no-port-appendwhen an override is present.Dirty serve sync has two separate targets. Dirty active-repo sync is enabled only when source materialization is dirty;
--cleandisables that active-repo sync. Local theme sync remains active even under--cleanso theme edits can still update the mountedrepo/themes/eips-themecopy while serving.The watcher syncs dirty active-repo paths and tracked local theme paths. Active repo markdown sync reruns markdown preprocessing after copying changed paths into the materialized repo.
This PR does not add targeted
serve --onlybehavior. Targeted serve filtering and selected-path sync land in V2:16.Verification
src/cli.rsfor serve-only--host/--portparsing.src/execution.rsfor server binding resolution from CLI, workspace config, and defaults.src/pipeline.rsforPrepared::serve, watcher startup/shutdown, active-repo sync configuration, local theme sync configuration, and Zola serve invocation.src/serve.rsfor dirty active-repo watching, local theme watching, Git index event handling, path sync, and markdown preprocessing after active-repo sync.src/zola.rsfor serve argument construction, server binding args, base URL override args, and output directory handling.Cargo.tomlandCargo.lockfor thenotifydependency.