[V2:10] Add Prepared Runtime Build Pipeline#24
Open
ritorhymes wants to merge 7 commits into
Open
Conversation
This was referenced May 5, 2026
6321df9 to
d023dd5
Compare
8aa5594 to
e2b0818
Compare
e2b0818 to
8c31bb8
Compare
Add workspace-local `.build-eips.toml` loading and starter configuration. Introduce `config::ActiveRepo` to load the selected checkout’s `Build.toml`, validate explicit `-C` roots, and expose active repository context to later commands. Keep source materialization, initialization, and diagnostics in their owning later branches.
Add clean and dirty source materialization for the active repository and sibling content. Use `config::RepositoryUse` throughout the runtime path, preserve tracked working-tree materialization and `index_path`, and reject dirty active manifests in clean modes. Build, check, and serve prepare sources without fetching the active upstream; `changed` retains upstream fetching for comparison.
Add workspace initialization from the selected active `Build.toml`. Clone missing sibling repositories from declared locations and initialize a missing theme checkout from the manifest repository and pin. Preserve existing usable checkouts and fail without deleting unusable paths. Write `.build-eips.toml` only when absent and generate `WORKSPACE.md` for the initialized workspace.
Add `build-eips doctor` for validating workspace configuration, active `Build.toml`, managed sibling repositories, the local theme checkout, and required tools. Report ok/warn/fail diagnostics; invalid active manifests and unusable theme configuration fail, while expected sibling and theme-pin conditions can warn. Keep diagnostics read-only and leave execution and runtime behavior to later branches.
Resolve build, check, and serve source policy around local active sources, clean mode, remote siblings, build roots, and base URL precedence. Keep `--clean` and `--remote-siblings` as source controls and limit `--only` to supported local dirty modes. Route runtime commands through one resolved execution policy.
Run Zola with the editable `workspace/theme` checkout. Materialize tracked local theme files into prepared `themes/eips-theme`, load Zola and eipw configuration from that local checkout, and keep runtime commands independent of manifest network access.
Add prepared runtime build pipeline. Materialize active and sibling sources according to resolved execution policy, preprocess merged proposal content, prepare the local theme mount, and invoke runtime checks and rendering from `pipeline.rs`. Keep serve watch and sync behavior in the serve runtime branch.
8c31bb8 to
4c2049d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the prepared runtime build pipeline out of
main.rsand intopipeline.rs, where it consumesResolvedExecutionfrom V2:08 and the workspace-local theme model from V2:09.Prepared::preparenow owns the full preparation sequence (disposable repo setup, source and sibling materialization, changed-file linting via eipw, markdown preprocessing, local theme materialization intorepo/themes/eips-theme, and Zola build/check), whilemain.rsis reduced to dispatch and locking. The move preserves build/check behavior aside from two small targeted fixes (sibling-merge homepage preservation and force-refresh of prepared scratch refs), so review should focus on the new ownership boundary, theme materialization, and verifying those fixes.pipeline.rsto own thePreparedruntime pipeline.main.rs.ResolvedExecutionto prepare the disposable build repo from resolved source, theme, build-root, and base-URL policy.repo/themes/eips-themebefore Zola runs.main.rsfocused on command dispatch, build-root creation, locking, and runtime operation selection.Review Notes
This PR is the prepared runtime ownership split. V2:08 resolves execution policy, V2:09 requires the workspace-local theme, and this PR centralizes the actual build/check preparation around those resolved inputs.
Prepared::preparenow owns the runtime preparation sequence: initialize the disposable build repo, clone/fetch the active source repo, collect changed proposal files for linting, merge sibling proposal sources, run eipw lint, preprocess markdown, and materialize the local theme for Zola.The theme handling changes shape here. V2:09 made Zola use a workspace-local theme; this PR materializes that local theme into the prepared repo under
repo/themes/eips-themebefore calling Zola, so Zola sees the normal mounted theme layout.This PR does not add new CLI surface. It preserves the existing build/check runtime behavior while moving the implementation out of
main.rs.The existing minimal
Prepared::servemethod moves withPreparedso the type remains coherent, but this PR does not add the dirty watcher, theme sync, server binding, or final serve behavior. Those land in V2:11.Verification
src/pipeline.rsforPrepared::prepare, source materialization, changed-file lint selection, sibling merge, markdown preprocessing, theme materialization, and build/check calls.src/main.rsfor the reduced dispatch-only runtime flow.src/find_root.rsfor the directcrate::layout::CONTENT_DIRimport now thatmain.rsno longer bringsCONTENT_DIRinto scope.repo/themes/eips-theme.