fix: make active and retired fields clearer (SubsidyAccessPolicy)#214
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the admin-facing help_text for the SubsidyAccessPolicy.retired flag to correct the described boolean polarity and keep the schema’s field metadata in sync via a migration.
Changes:
- Updates
SubsidyAccessPolicy.retiredhelp text to reflect the intended meaning of theretiredflag. - Adds a Django migration to update the
retiredfield help text for bothSubsidyAccessPolicyand its historical model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
enterprise_access/apps/subsidy_access_policy/models.py |
Adjusts the retired field’s help_text shown in admin/forms. |
enterprise_access/apps/subsidy_access_policy/migrations/0031_fix_subsidyaccesspolicy_retired_helptext.py |
Applies the help text update at the DB schema metadata level for both current and historical models. |
Comment on lines
195
to
200
| retired = models.BooleanField( | ||
| default=False, | ||
| help_text=( | ||
| "True means redeemability of content using this policy has been enabled. " | ||
| "Set this to False to deactivate the policy but keep it visible from an admin's perspective " | ||
| "False means redeemability of content using this policy has been enabled. " | ||
| "Set this to True to deactivate the policy but keep it visible from an admin's perspective " | ||
| "(useful when you want to just expire a policy without expiring the whole plan)." |
Contributor
There was a problem hiding this comment.
Is this feedback from co-pilot true?
| migrations.AlterField( | ||
| model_name='historicalsubsidyaccesspolicy', | ||
| name='retired', | ||
| field=models.BooleanField(default=False, help_text="False means redeemability of content using this policy has been enabled. Set this to True to deactivate the policy but keep it visible from an admin's perspective (useful when you want to just expire a policy without expiring the whole plan)."), |
| migrations.AlterField( | ||
| model_name='subsidyaccesspolicy', | ||
| name='retired', | ||
| field=models.BooleanField(default=False, help_text="False means redeemability of content using this policy has been enabled. Set this to True to deactivate the policy but keep it visible from an admin's perspective (useful when you want to just expire a policy without expiring the whole plan)."), |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 86.44% 86.44%
=======================================
Files 154 154
Lines 12848 12848
Branches 1227 1227
=======================================
Hits 11107 11107
Misses 1426 1426
Partials 315 315 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brobro10000
approved these changes
Jun 24, 2026
brobro10000
left a comment
brobro10000
left a comment
Contributor
There was a problem hiding this comment.
Approved to unblock. Only 1 copilot to double check on.
Comment on lines
195
to
200
| retired = models.BooleanField( | ||
| default=False, | ||
| help_text=( | ||
| "True means redeemability of content using this policy has been enabled. " | ||
| "Set this to False to deactivate the policy but keep it visible from an admin's perspective " | ||
| "False means redeemability of content using this policy has been enabled. " | ||
| "Set this to True to deactivate the policy but keep it visible from an admin's perspective " | ||
| "(useful when you want to just expire a policy without expiring the whole plan)." |
Contributor
There was a problem hiding this comment.
Is this feedback from co-pilot true?
pwnage101
force-pushed
the
pwnage101/fix-policy-retired-helptext
branch
from
f61feae to
ae65a3b
Compare
pwnage101
changed the title
retired field (SubsidyAccessPolicy)active and retired fields clearer (SubsidyAccessPolicy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.