Skip to content

[#24574] Fix macOS build issues in YAML parsing and CLI arguments #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danipiza merged 1 commit into from
Jun 2, 2026
+5 −7
Merged

[#24574] Fix macOS build issues in YAML parsing and CLI arguments #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastddsspy_tool/src/cpp/user_interface/arguments_configuration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const option::Descriptor usage[] = {
},

{
optionIndex::DOMAIN,
optionIndex::DOMAIN_ID,
0,
"",
"domain",
Expand Down Expand Up @@ -260,7 +260,7 @@ ProcessReturnCode parse_arguments(
utils::VerbosityKind(static_cast<int>(from_string_LogKind(opt.arg)));
break;

case optionIndex::DOMAIN:
case optionIndex::DOMAIN_ID:
{
const auto max_domain_id = static_cast<long>(ddspipe::core::types::DomainId::MAX_DOMAIN_ID);
long domain_value = 0;
Expand Down
2 changes: 1 addition & 1 deletion fastddsspy_tool/src/cpp/user_interface/arguments_configuration.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ enum optionIndex
VERSION,
LOG_FILTER,
LOG_VERBOSITY,
DOMAIN,
DOMAIN_ID,
};

/**
Expand Down
6 changes: 2 additions & 4 deletions fastddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,9 @@ void Configuration::load_dds_configuration_(

for (const auto& topic: manual_topics)
{
const std::string key(topic.first->topic_name);
const std::string key(topic.first->topic_name.get_reference());

// force an unambiguous std::string
const std::string filter =
static_cast<std::string>(topic.first->content_topic_filter);
const std::string filter = topic.first->content_topic_filter.get_reference();

auto ret = dds_configuration->content_topic_filter_dict.insert(
std::make_pair(key, filter)
Expand Down
Loading