Skip to content

[#24574] Fix macOS build issues in YAML parsing and CLI arguments#150

Merged
Danipiza merged 1 commit into
mainfrom
fix/macos-compilation
Jun 2, 2026
Merged

[#24574] Fix macOS build issues in YAML parsing and CLI arguments#150
Danipiza merged 1 commit into
mainfrom
fix/macos-compilation

Conversation

@Danipiza

Copy link
Copy Markdown
Contributor

Description

This PR fixes two macOS compilation issues in Fast DDS Spy.

Changes

  1. Make std::string extraction explicit in fastddsspy_yaml by using get_reference() instead of relying on implicit conversion from utils::Fuzzy<std::string>.
  2. Rename the CLI option enum entry DOMAIN to DOMAIN_ID in fastddsspy_tool to avoid colliding with the DOMAIN macro defined by macOS system headers.

Errors

1.

--- stderr: fastddsspy_yaml                             
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp:189:31: error: call to constructor of 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char>>') is ambiguous
  189 |             const std::string key(topic.first->topic_name);
      |                               ^   ~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:822:5: note: candidate constructor
  822 |     basic_string(const basic_string& __str);
      |     ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:827:5: note: candidate constructor
  827 |     basic_string(basic_string&& __str)
      |     ^
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp:193:21: error: ambiguous conversion for static_cast from 'utils::Fuzzy<std::string>' (aka 'Fuzzy<basic_string<char, char_traits<char>, allocator<char>>>') to 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>')
  193 |                     static_cast<std::string>(topic.first->content_topic_filter);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:822:5: note: candidate constructor
  822 |     basic_string(const basic_string& __str);
      |     ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:827:5: note: candidate constructor
  827 |     basic_string(basic_string&& __str)

2.

In file included from /Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.cpp:30:
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.hpp:102:5: error: expected identifier
  102 |     DOMAIN,
      |     ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/math.h:781:17: note: expanded from macro 'DOMAIN'
  781 | #define DOMAIN          1
      |                         ^
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.cpp:105:22: error: expected unqualified-id
  105 |         optionIndex::DOMAIN,

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.63%. Comparing base (545fdbf) to head (ba16cc1).

Files with missing lines Patch % Lines
...astddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp 0.00% 0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (545fdbf) and HEAD (ba16cc1). Click for more details.

HEAD has 57 uploads less than BASE
Flag BASE (545fdbf) HEAD (ba16cc1)
58 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   62.09%   56.63%   -5.47%     
==========================================
  Files          29       28       -1     
  Lines        2509     1960     -549     
  Branches     1074      772     -302     
==========================================
- Hits         1558     1110     -448     
+ Misses        385      368      -17     
+ Partials      566      482      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Danipiza Danipiza requested a review from ZakariaTalbi May 28, 2026 09:00

@ZakariaTalbi ZakariaTalbi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Danipiza Danipiza merged commit faaa92a into main Jun 2, 2026
18 of 20 checks passed
@Danipiza Danipiza deleted the fix/macos-compilation branch June 2, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants