Skip to content

Large batch of typing fixes for #151 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskrypa merged 5 commits into from
Mar 14, 2026
Merged

Large batch of typing fixes for #151 #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a821749
another batch of type annotation fixes for #151
dskrypa Mar 12, 2026
c13ca78
#151 type annotation fixes for numeric/choice inputs; fixed handling …
dskrypa Mar 13, 2026
bea1e4f
fixed type annotations for pattern/time inputs for #151
dskrypa Mar 13, 2026
39c3b92
fixed most type annotation issues in the argparse to cli-command-pars…
dskrypa Mar 14, 2026
af08059
started fixing type annotations in parameters.base for #151
dskrypa Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/cli_command_parser/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
if TYPE_CHECKING:
from .command_parameters import CommandParameters
from .commands import Command
from .core import CommandMeta
from .parameters import ActionFlag, BaseOption, Parameter
from .typing import AnyConfig, Bool, CommandObj, CommandType, OptStr, ParamOrGroup, PathLike, StrSeq # noqa
from .typing import AnyConfig, Bool, CommandCls, CommandObj, OptStr, ParamOrGroup, PathLike, StrSeq

Argv = StrSeq | None

Expand Down Expand Up @@ -53,7 +54,7 @@ class Context(AbstractContextManager): # Extending AbstractContextManager to ma
def __init__(
self,
argv: Argv = None,
command_cls: CommandType | None = None,
command_cls: CommandCls | None = None,
*,
parent: Context | None = None,
config: AnyConfig | None = None,
Expand Down Expand Up @@ -100,7 +101,7 @@ def _set_argv(self, prog: OptStr, argv: Argv):
self.remaining = list(self.argv)

def _sub_context(
self, command_cls: CommandType, argv: Argv = None, command: CommandObj | None = None, **kwargs
self, command_cls: CommandCls, argv: Argv = None, command: CommandObj | None = None, **kwargs
) -> Context:
return self.__class__(
self.remaining if argv is None else argv,
Expand Down Expand Up @@ -322,7 +323,7 @@ def iter_action_flags(self, phase: ActionPhase) -> Iterator[ActionFlag]:


def _normalize_config(
config: AnyConfig, kwargs: dict[str, Any], parent: Context | None, command: CommandType | None
config: AnyConfig, kwargs: dict[str, Any], parent: Context | None, command: CommandMeta | None
) -> CommandConfig:
if config is not None:
if kwargs:
Expand Down Expand Up @@ -443,7 +444,7 @@ def get_current_context(silent: bool = False) -> Context | None:


def get_or_create_context(
command_cls: CommandType, argv: Argv = None, *, command: CommandObj | None = None, **kwargs
command_cls: CommandCls, argv: Argv = None, *, command: CommandObj | None = None, **kwargs
) -> Context:
"""
Used internally by Commands to re-use an existing user-activated Context, or to create a new Context if there was
Expand Down
Loading
Loading