Skip to content

Large batch of typing fixes for #151#153

Merged
dskrypa merged 5 commits into
mainfrom
dev
Mar 14, 2026
Merged

Large batch of typing fixes for #151#153
dskrypa merged 5 commits into
mainfrom
dev

Conversation

@dskrypa

@dskrypa dskrypa commented Mar 14, 2026

Copy link
Copy Markdown
Owner

Related to #151, this PR fixes type annotations for a large batch of modules.

Some minor logic tweaks/fixes are included, as well as many docstring / comment additions.

@codecov

codecov Bot commented Mar 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.47826% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.40%. Comparing base (374cde8) to head (af08059).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/cli_command_parser/conversion/visitor.py 86.36% 4 Missing and 5 partials ⚠️
lib/cli_command_parser/parameters/base.py 86.95% 1 Missing and 5 partials ⚠️
lib/cli_command_parser/conversion/argparse_ast.py 93.22% 0 Missing and 4 partials ⚠️
lib/cli_command_parser/inputs/time.py 90.90% 0 Missing and 2 partials ⚠️
lib/cli_command_parser/inputs/utils.py 92.00% 0 Missing and 2 partials ⚠️
lib/cli_command_parser/conversion/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   97.66%   97.40%   -0.27%     
==========================================
  Files          52       52              
  Lines        6946     7005      +59     
  Branches     1097     1119      +22     
==========================================
+ Hits         6784     6823      +39     
- Misses        127      131       +4     
- Partials       35       51      +16     
Flag Coverage Δ
unittests 97.37% <92.93%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dskrypa dskrypa merged commit 7e85aa0 into main Mar 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant