Add password support and recursive folder download for shared links#258
Merged
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--password,--password-prompt,--password-fileflags toshare-link create,share-link update, andshare-link download--remove-passwordflag toshare-link update--recursive(-r) flag toshare-link downloadfor folder shared linksgolang.org/x/termfor secure non-echoing terminal inputRemoveSharedLinkPassworduses raw SDK request to sendrequire_password: false(not exposed by the Go SDK'sModifySharedLinkSettings)files.ListFolderwith shared link context, and per-file retry.., empty components, and absolute pathsDepends on #257.
Test plan
--passwordsets password on create, update, and download--password-promptreads from terminal/stdin without echo--password-filereads and trims trailing newlines--remove-passwordsendsrequire_password: falsevia raw API call--password+--remove-passwordmutually exclusive on update--recursiveflagRemoveSharedLinkPasswordJSON payload