Add --disallow-download, --path for info, and password for info#259
Merged
Conversation
Add share-link create/update support for download and password settings, including raw settings RPCs for fields the generated SDK cannot represent with false values. Add share-link info path/password support and update docs/tests for the new flags.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disallow-downloadflag toshare-link createandshare-link update(uses raw API to sendallow_download: false)--pathflag toshare-link infoto inspect a nested file inside a shared folder link--password,--password-prompt,--password-file) toshare-link infomodifySharedLinkSettingsRawwithrawSharedLinkSettingsusing*boolfieldsDepends on #258.
Test plan
--disallow-downloadon create disables downloads after link creation--disallow-downloadon existing link uses raw API call--allow-download+--disallow-downloadmutually exclusive (create and update)--disallow-downloadon update skips ModifySharedLinkSettings, calls raw APIallow_download: falseJSON payload--pathon info passes path to GetSharedLinkMetadata--pathrejected