Let notifications close after a set time

apps/review-desktop/code-oss/src/vs/review/browser/reviewNotification.ts

@@ -5,7 +5,7 @@ import type { ReviewDisposable, ReviewNotification } from "../common/reviewProto
 
 export function showReviewNotification(
   notifications: Pick<INotificationService, "notify">,
-  { kind, text, actions, onClose }: ReviewNotification,
+  { kind, text, actions, closeAfterMs, onClose }: ReviewNotification,
 ): ReviewDisposable {
   const handle = notifications.notify({
     severity: kind === "error" ? Severity.Error : Severity.Info,
@@ -14,6 +14,10 @@ export function showReviewNotification(
       ? { primary: actions.map((action, index) => toAction({ id: `review.notification.${index}`, label: action.label, run: () => action.run() })) }
       : undefined,
   });
+  if (closeAfterMs !== undefined) {
+    const timer = setTimeout(() => handle.close(), closeAfterMs);
+    Event.once(handle.onDidClose)(() => clearTimeout(timer));
+  }
   if (onClose) Event.once(handle.onDidClose)(onClose);
   return { dispose: () => handle.close() };
 }

packages/review-protocol/src/contracts.ts

@@ -370,6 +370,7 @@ export interface ReviewNotification {
   kind: "success" | "error";
   text: string;
   actions?: readonly { label: string; run(): void }[];
+  closeAfterMs?: number;
   onClose?(): void;
 }
 

packages/review/app/src/agent-selection.test.tsx

@@ -137,6 +137,7 @@ it("copies only on click or Shift+Cmd+C, reports failures, and clears on revisio
     expect(notify).toHaveBeenLastCalledWith({
       kind: "success",
       text: expect.stringContaining("copied to clipboard"),
+      closeAfterMs: 5_000,
     });
     expect(container.querySelector('[role="status"]')).toBeNull();
     await act(async () => {

packages/review/app/src/agent-selection.tsx

@@ -235,6 +235,7 @@ export function AgentSelectionProvider({
       notify({
         kind: "success",
         text: "Selection copied to clipboard. Paste into your agent to chat about it.",
+        closeAfterMs: 5_000,
       });
     } catch {
       setCopiedSelection(null);

packages/review/app/src/ask-setup.tsx

@@ -34,6 +34,7 @@ export function AskSetup({
       notify({
         kind: "success",
         text: "Selection copied to clipboard. Paste into your agent to chat about it.",
+        closeAfterMs: 5_000,
       });
     } catch {
       notify({

packages/review/app/src/bug-report-dialog.browser.test.tsx

@@ -70,6 +70,7 @@ describe("BugReportControl", () => {
     expect(notify).toHaveBeenCalledWith({
       kind: "success",
       text: "Bug report was sent.",
+      closeAfterMs: 5_000,
     });
     expect(container.querySelector("dialog")).toBeNull();
   });

packages/review/app/src/bug-report-dialog.tsx

@@ -132,6 +132,7 @@ export function BugReportControl({
       notify({
         kind: "success",
         text: "Bug report was sent.",
+        closeAfterMs: 5_000,
       });
       reset();
       setOpen(false);

packages/review/app/src/onboarding/draw-flow.tsx

@@ -71,6 +71,7 @@ export function DrawFlow({
           ? {
               kind: "success",
               text: "Prompt copied. Paste it into your agent.",
+              closeAfterMs: 5_000,
             }
           : {
               kind: "error",

packages/review/app/src/review-home-view.tsx

@@ -955,6 +955,7 @@ function ReviewHomeBody({
             ? {
                 kind: "success",
                 text: "Copied 'founders@dev.fast' to clipboard",
+                closeAfterMs: 5_000,
               }
             : { kind: "error", text: "Couldn't copy email. Please try again." },
         );