-
Notifications
You must be signed in to change notification settings - Fork 44
DLPX-89763 DLPX-86523 delphix-platform changes #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justsanjeev
wants to merge
8
commits into
develop
Choose a base branch
from
dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d9eb0d2
Adding logic to take case the /export/home mount before delting /expo…
justsanjeev 968ecba
removing /export/home since it was empty, found in manual check
justsanjeev 0a51c72
Adding the logic to move the contents of /export/home if its not empt…
justsanjeev 74a097e
Updating copyright header
justsanjeev 298ee15
Moving this logic to appliance-build, for testing purpose keeping fil…
justsanjeev f0a04c9
Fixing the etc/fstab mount option during upgrade here.
justsanjeev 64fe711
Removing preinst script, the logic moved to appliance-build
justsanjeev 4e091fb
Fixing the message with proper handling suggestion in case of symlink…
justsanjeev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Copyright (c) 2026 by Delphix. All rights reserved. | ||
| # | ||
|
|
||
| # | ||
| # This script ensures that the /export/home is a symlink | ||
| # to /home. | ||
| # | ||
|
|
||
| # If /export/home is already a symlink to /home, do nothing | ||
| if [ -L /export/home ]; then | ||
| echo '/export/home is already exists. Nothing to do.' | ||
| exit 0 | ||
| fi | ||
|
|
||
| # if /export/home and /home both are mounted - Dont do anything | ||
| # Since during the next boot /export/home will not be mounted | ||
| # Since /export/home is there all tests will be passes | ||
| if mountpoint -q /export/home; then | ||
| echo '/export/home is still mounted. Check if /home is also mounted' | ||
| if mountpoint -q /home; then | ||
| echo '/home is also mounted. Since during the next boot /export/home will not be mounted, exiting safely.' | ||
| exit 0 | ||
| else | ||
| echo '/home is not mounted. Aborting!!' | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| # /export/home is not mounted, check if /home is mounted | ||
| if mountpoint -q /home; then | ||
| echo "/home is mounted. Proceeding with /export/home cleanup." | ||
| # If /export/home exists | ||
| if [ -d /export/home ]; then | ||
| echo "/export/home exists. Attempting to remove it..." | ||
| rmdir /export/home 2>/dev/null | ||
|
justsanjeev marked this conversation as resolved.
|
||
| if [ $? -eq 0 ]; then | ||
| echo "/export/home directory removed successfully." | ||
| else | ||
| # If rmdir fails, it means /export/home is not empty | ||
| # Move contents to a backup location for a seamless user experience. | ||
| echo "/export/home is not empty. Moving contents to /export/home.backup before cleanup..." | ||
| backup_dir="/export/home.backup.$(date +%Y%m%d_%H%M%S)" | ||
| mv /export/home "$backup_dir" | ||
| if [ $? -ne 0 ]; then | ||
| echo "Failed to move /export/home contents to backup. Manual intervention required." | ||
| exit 1 | ||
| fi | ||
|
justsanjeev marked this conversation as resolved.
|
||
| echo "Contents of /export/home moved successfully to: $backup_dir" | ||
|
justsanjeev marked this conversation as resolved.
|
||
| fi | ||
| fi | ||
| else | ||
| echo "/home is not mounted. Aborting to avoid risk of data loss." | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Ensure /export exists | ||
| mkdir -p /export | ||
|
|
||
| # Create symlink | ||
| echo "Creating symlink: /export/home -> /home" | ||
| if ln -s /home /export/home; then | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you remind me why we want to preserve this symlink? |
||
| echo "Symlink created successfully." | ||
| else | ||
| echo "Failed to create symlink /export/home -> /home. Check that /export exists, is writable, and no stale /export/home entry remains. Re-run this script after resolving." | ||
| exit 1 | ||
| fi | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.