DLPX-89763 DLPX-86523 delphix-platform changes by justsanjeev · Pull Request #477 · delphix/delphix-platform

justsanjeev · 2024-04-18T14:34:45Z

Problem

CIS is looking or a single home directory filesystem mounted at the /home location, currently we have the home dataset is mounted on /export/home

Due to that we see the below issues in the CIS Report

(1.45) 7402 Status of the '/home' partition in the '/etc/fstab' file
(1.46) 13248 Status of Mount Partition '/home' using mount command
(1.47) 7403 Status of the 'nodev' mount option setting for the '/home partition' defined in the '/etc/ fstab' file
(1.48) 14601 Status of the 'nodev' option for '/home' partition using 'mount' command

Solution

Mounting the home dataset to /home.
Post upgrade creating a softlink /export/home to /home so that the exiting tests and dependencies have minimal impact.

With implemented a a script which takes care of a soft link creation with files/common/var/lib/delphix-platform/export-home. This ensure. a softlink from /export/home to /home. This helps to ensure that most of the flows are passed with this new implementation.

Testing Done

Refer testing section in delphix/appliance-build#756

…rt/home Adding the mount point logic back to delphix-platform.sh script Changing as per Seb-s comment to alter the softlink logic. Changing the code to previous version to validate the comments. Changing the delphix-legacy-link.service to perform the same steps next reboot like deferred upgrade. Creating a different service for taking care of soft /export/home -> /home DLPX-89763 DLPX-86523 delphix-platform changes Moved the code to create symlink to different script Removing the autofs handling as per the concerns raised by Seb and our validation Removing the softlink loginc from main.yml Since /export/home has empty delphix directory, taking care Taking care the comments from Seb on 16 July 2025. handling /export/home and /home both mounted, validated in mount | grep home check PR URL: https://www.github.com/delphix/delphix-platform/pull/477

…y, for a better user experience.

…e contents commented.

… creation failure.

prakashsurya · 2026-06-01T16:21:18Z

+
+# Create symlink
+echo "Creating symlink: /export/home -> /home"
+if ln -s /home /export/home; then


can you remind me why we want to preserve this symlink?

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from ec9dada to 317e58e Compare April 18, 2024 14:34

prakashsurya reviewed May 8, 2024

View reviewed changes

Comment thread ...n/var/lib/delphix-platform/ansible/10-delphix-platform/roles/delphix-platform/tasks/main.yml

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from 317e58e to 68118d0 Compare June 24, 2024 09:31

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from 68118d0 to e56b7de Compare July 2, 2024 11:54

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 4 times, most recently from a4f876c to d356ef1 Compare July 11, 2024 10:29

justsanjeev mentioned this pull request Jul 12, 2024

DLPX-89763 DLPX-86523 delphix-platform changes #487

Closed

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 5 times, most recently from 38fba97 to 28cab6b Compare July 16, 2024 07:08

justsanjeev mentioned this pull request Jul 16, 2024

DLPX-89763 DLPX-86523 delphix-platform changes #473

Closed

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from b1d61e7 to 0c718f3 Compare September 25, 2024 17:25

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from b984a71 to f389cbe Compare October 7, 2024 10:17

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from 64091f7 to 5022542 Compare October 22, 2024 11:48

justsanjeev mentioned this pull request Oct 24, 2024

DLPX-86523 CIS: /home filesystem and mount options delphix/appliance-build#756

Open

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from 5022542 to 744dc46 Compare November 4, 2024 07:54

justsanjeev marked this pull request as ready for review November 5, 2024 10:42

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 3 times, most recently from d39c466 to 52eee14 Compare November 25, 2024 07:26

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 3 times, most recently from b5743b5 to 3a9629e Compare December 3, 2024 08:11

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from e22f588 to 26210f6 Compare June 30, 2025 16:20

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from 8b5f0fb to a5ef067 Compare July 13, 2025 07:15

sebroy requested changes Jul 16, 2025

View reviewed changes

Comment thread debian/postinst Outdated

Comment thread files/common/var/lib/delphix-platform/export-home Outdated

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from eba0198 to b36fe93 Compare July 21, 2025 11:47

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from 3c17e95 to 64f43bb Compare September 11, 2025 07:40

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 2 times, most recently from 07b0466 to c092613 Compare October 6, 2025 06:47

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from c092613 to 33fadf6 Compare October 31, 2025 10:02

sebroy requested changes Nov 6, 2025

View reviewed changes

Comment thread files/common/var/lib/delphix-platform/export-home Outdated

Comment thread files/common/var/lib/delphix-platform/export-home Outdated

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch 3 times, most recently from 7f327d7 to c93d76f Compare December 16, 2025 10:37

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from c93d76f to f1018a0 Compare December 23, 2025 15:26

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from f1018a0 to a370f69 Compare January 5, 2026 10:14

justsanjeev mentioned this pull request Jan 13, 2026

test changes duplicate with execStart #525

Closed

sebroy approved these changes Jan 15, 2026

View reviewed changes

prakashsurya reviewed Jan 26, 2026

View reviewed changes

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from 4763660 to 8e366ed Compare January 29, 2026 16:00

justsanjeev added 7 commits March 25, 2026 14:10

removing /export/home since it was empty, found in manual check

968ecba

Adding the logic to move the contents of /export/home if its not empt…

0a51c72

…y, for a better user experience.

Updating copyright header

74a097e

Moving this logic to appliance-build, for testing purpose keeping fil…

298ee15

…e contents commented.

Fixing the etc/fstab mount option during upgrade here.

f0a04c9

Removing preinst script, the logic moved to appliance-build

64fe711

justsanjeev force-pushed the dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951 branch from 8e366ed to 64fe711 Compare April 17, 2026 08:06

Fixing the message with proper handling suggestion in case of symlink…

4e091fb

… creation failure.

prakashsurya reviewed Jun 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DLPX-89763 DLPX-86523 delphix-platform changes#477

DLPX-89763 DLPX-86523 delphix-platform changes#477
justsanjeev wants to merge 8 commits into
developfrom
dlpx/pr/justsanjeev/ef30769e-a58a-4475-af32-174db6d07951

justsanjeev commented Apr 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prakashsurya Jun 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

justsanjeev commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing Done

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prakashsurya Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

justsanjeev commented Apr 18, 2024 •

edited

Loading

prakashsurya Jun 1, 2026 •

edited

Loading