Skip to content

Extend Sapat Providers in Daytona#181

Open
jjoanna2-debug wants to merge 9 commits into
daytonaio:mainfrom
jjoanna2-debug:extend-sapat-providers-daytona
Open

Extend Sapat Providers in Daytona#181
jjoanna2-debug wants to merge 9 commits into
daytonaio:mainfrom
jjoanna2-debug:extend-sapat-providers-daytona

Conversation

@jjoanna2-debug

@jjoanna2-debug jjoanna2-debug commented May 11, 2026

Copy link
Copy Markdown

Summary

  • Refresh the Daytona guide for current Sapat provider-registry architecture and the dynamic --provider CLI flow.
  • Ground the guide in live Sapat source behavior: provider discovery, TranscriptionProvider, ProviderConfig, TranscriptionResult, mocked validation, and security/privacy guardrails.
  • Add a provider selection matrix, provider acceptance matrix, provider security checklist, maintainer review checklist, transcription provider adapter definition, original workflow PNG, and first-time author profile.

Decisive review points

  • Wrong architecture avoided: the guide targets current Sapat provider modules under sapat/providers/, @register, and dynamic --provider discovery. It does not teach the stale hard-coded --api path.
  • Abstract-contract gap closed: the AssemblyAIProvider(AsyncPollProvider) sample includes all required async hooks: _upload, _poll, and _fetch_result.
  • Review burden reduced: the acceptance matrix gives maintainers concrete rows to check: CLI selection, secret loading, audio handoff, job lifecycle, retry/timeout behavior, return shape, error privacy, and regression guard.
  • Content-only risk bounded: the branch adds one guide, one definition, one author profile, and one PNG. It does not modify Daytona runtime code or introduce executable dependencies.

Security / privacy hardening

  • API keys stay in environment variables or workspace secrets; no keys belong in README examples, screenshots, logs, PR bodies, or fixtures.
  • Endpoint overrides must be HTTPS, must not carry query-string secrets, and should point only at the provider host or an approved test double.
  • Live validation uses short non-sensitive clips only; private calls, unreleased demos, medical files, legal recordings, generated transcripts, and payout details stay out of commits.
  • Provider errors must not log authorization headers, raw .env values, full provider responses, or full transcript text.
  • Temporary MP3 output and smoke-test artifacts are explicitly part of the cleanup/review checklist.

Current validation

  • npx --yes markdownlint-cli@0.45.0 guides/20260511_extend_sapat_providers_in_daytona.md definitions/20260511_definition_transcription_provider_adapter.md authors/jean_claude_joanna.md
  • git diff --check origin/main...HEAD
  • Secret-pattern scan across the changed author, definition, guide, and PNG paths: no high-confidence token/private-key/API-key hits.
  • PNG asset verification: guides/assets/20260511_extend_sapat_providers_in_daytona_img1.png parses as a valid 1600x900 PNG.
  • Live Sapat source re-check: provider registry, @register, dynamic --provider, ProviderConfig, TranscriptionResult, AsyncPollProvider, and temporary-audio cleanup are still present upstream.
  • DCO is green on the latest pushed commit.

/claim #13

Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from bd00a05 to f05d014 Compare May 11, 2026 13:32
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 53b9be4 to 296c99d Compare May 11, 2026 20:52
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 156fb1d to 57a29c7 Compare May 13, 2026 03:11
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 740e3f4 to fcaff6e Compare May 13, 2026 23:50
Jean-Claude Joanna added 2 commits May 14, 2026 23:33
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 62a4f16 to c992ef7 Compare May 19, 2026 22:46
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 864830e to 88cd1ca Compare May 30, 2026 21:43
Signed-off-by: Jean-Claude Joanna <273834277+jjoanna2-debug@users.noreply.github.com>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from dd7b357 to 0710f5a Compare May 30, 2026 22:08
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch 2 times, most recently from dc766aa to 520c2d8 Compare June 19, 2026 23:48
Signed-off-by: Jean-Claude Joanna <273834277+jjoanna2-debug@users.noreply.github.com>
@jjoanna2-debug jjoanna2-debug force-pushed the extend-sapat-providers-daytona branch from 520c2d8 to a0fda00 Compare June 19, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant