Skip to content

Commit c992ef7

Browse files
Jean-Claude JoannaJean-Claude Joanna
authored andcommitted
Tighten provider review guardrails
Signed-off-by: Jean-Claude Joanna <jeanclaudejoanna@JCs-M3-MacBook-Pro.local>
1 parent f0caf4a commit c992ef7

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

guides/20260511_extend_sapat_providers_in_daytona.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,9 @@ marketing surface.
181181
| Secret loading | `ASSEMBLYAI_API_KEY` | missing-key test raises a useful error |
182182
| Audio handoff | upload converted MP3 | mocked upload request receives the file |
183183
| Job lifecycle | submit, poll, complete | mocked completed and failed job responses |
184+
| Retry boundary | rate limits, timeouts, slow jobs | mocked retry/backoff and timeout cases |
184185
| Return shape | `{"text": "..."}` | base class writes the transcript `.txt` |
186+
| Error privacy | provider errors and request metadata | tests/log review show no API keys or full transcript text |
185187
| Regression guard | existing providers unchanged | compile OpenAI, Groq, and Azure modules |
186188

187189
If one row cannot be proven yet, keep it explicit in the PR body. Maintainers
@@ -224,6 +226,8 @@ guardrail pass catches most mistakes:
224226
deliberately public fixtures created for review.
225227
- Redact provider request IDs, account IDs, and full transcript text from public
226228
review notes unless the sample was created for public testing.
229+
- Do not log authorization headers, raw `.env` values, or full provider
230+
response bodies when raising provider errors.
227231
- Mock upload, polling, timeout, and provider-error paths in tests so the branch
228232
can be reviewed without spending credits or exposing real audio.
229233
- Keep endpoint overrides explicit. If the provider supports a custom endpoint,

0 commit comments

Comments
 (0)