Skip to content

Add ReportGenerator to baseline exclude filters (coverlet.MTP) #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bertk merged 1 commit into from
Jun 3, 2026
+5 −6
Merged

Add ReportGenerator to baseline exclude filters (coverlet.MTP) #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coverlet.MTP/Configuration/CoverageConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal sealed class CoverageConfiguration

// Permanent baseline: coverlet assemblies must always be excluded regardless of source.
// All other test-framework assemblies are discovered dynamically at runtime via IProcessAssemblyHelper.
private static readonly string[] s_baselineExcludeFilters = ["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*"];
private static readonly string[] s_baselineExcludeFilters = ["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*", "[ReportGenerator.*]*"];
Comment thread
Bertk marked this conversation as resolved.
Comment thread
Bertk marked this conversation as resolved.

private static readonly string[] s_defaultExcludeByAttributes =
[
Expand Down
9 changes: 4 additions & 5 deletions test/coverlet.MTP.tests/Configuration/CoverageConfigurationDynamicExcludeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void WhenNoConfigFileThenDepsJsonFiltersApplied()
{
_mockProcessAssemblyHelper
.Setup(x => x.GetDepsJsonAssemblyNames(s_fakeModuleDir, TestAssemblyName))
.Returns(["xunit.core", "ReportGenerator.Mtp"]);
.Returns(["xunit.core"]);
_mockProcessAssemblyHelper
.Setup(x => x.GetLoadedAssemblyNames(TestAssemblyName))
.Returns([]);
Expand All @@ -62,7 +62,6 @@ public void WhenNoConfigFileThenDepsJsonFiltersApplied()
string[] result = config.GetExcludeFilters();

Assert.Contains("[xunit.core]*", result);
Assert.Contains("[ReportGenerator.Mtp]*", result);
}

[Fact]
Expand Down Expand Up @@ -106,7 +105,7 @@ public void WhenDepsJsonHelperReturnsEmptyListThenBaselineFallbackUsed()

string[] result = config.GetExcludeFilters();

Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*"], result);
Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*", "[ReportGenerator.*]*"], result);
}

[Fact]
Expand All @@ -127,7 +126,7 @@ public void WhenDepsJsonHelperThrowsThenBaselineFallbackUsed()

string[] result = config.GetExcludeFilters();

Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*"], result);
Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*", "[ReportGenerator.*]*"], result);
}

[Fact]
Expand Down Expand Up @@ -166,7 +165,7 @@ public void WhenNullTestModulePathThenBaselineOnlyReturned()

string[] result = config.GetExcludeFilters();

Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*"], result);
Assert.Equal(["[coverlet.*]*", "[Microsoft.VisualStudio.TestPlatform.*]*", "[testhost*]*", "[ReportGenerator.*]*"], result);
_mockProcessAssemblyHelper.Verify(
x => x.GetDepsJsonAssemblyNames(It.IsAny<string>(), It.IsAny<string>()),
Times.Never);
Expand Down
Loading