Add ReportGenerator to baseline exclude filters (coverlet.MTP)#1958
Merged
Conversation
Update CoverageConfiguration to always exclude "[ReportGenerator.*]*" assemblies. Adjust related tests in CoverageConfigurationDynamicExcludeTests to reflect the new baseline filter and remove dynamic exclusion expectations for ReportGenerator.
Bertk
added
driver-MTP
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates coverlet.MTP’s default exclusion behavior to prevent instrumentation of ReportGenerator assemblies, addressing the crash described in #1934 where ReportGenerator.Mtp.dll can be locked/in-use during instrumentation.
Changes:
- Added
"[ReportGenerator.*]*"to the baseline exclude filters inCoverageConfiguration. - Updated
CoverageConfigurationDynamicExcludeTestsexpectations to reflect the new baseline filter and to stop expecting a dynamic exclude specifically forReportGenerator.Mtp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coverlet.MTP/Configuration/CoverageConfiguration.cs | Extends baseline exclude filters to include ReportGenerator assemblies. |
| test/coverlet.MTP.tests/Configuration/CoverageConfigurationDynamicExcludeTests.cs | Adjusts dynamic-exclude tests to align with the new baseline exclusion behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CoverageConfiguration to exclude "[ReportGenerator.*]*" assemblies. Adjust related tests in CoverageConfigurationDynamicExcludeTests to reflect the new baseline filter and remove dynamic exclusion expectations for ReportGenerator.
#1934