lib: Removing SEV from Tee Enum#78
Conversation
|
Can you add a commit bumping the version to 0.15.0? Since this is a breaking change. |
Xynnn007
left a comment
Xynnn007
left a comment
There was a problem hiding this comment.
Thanks for this! One comment from my side
| let data = r#" | ||
| { | ||
| "version": "0.0.0", | ||
| "tee": "sev", |
There was a problem hiding this comment.
Could you help to replace sev here to tdx and change line 354 to Tee::Tdx? This unit test aims to test parse request.
There was a problem hiding this comment.
Done, readded the test with the changes.
arvindskumar99
force-pushed
the
SEV-deprec
branch
2 times, most recently
from
bcf684e to
aa6914e
Compare
Done |
mythi
left a comment
mythi
left a comment
There was a problem hiding this comment.
LGTM
The linter error is not related to this PR but something rust stable with 1.91 triggers.
|
Hi @arvindskumar99 could you take a rebase, which would help to fix the CI? |
Rust requires all posibilities to be exhausted when matching an enum, and the Tee::SEV reference is being removed in trustee/deps/verifier/src/lib.rs in PR #984 in the trustee PR. So to avoid a compilation error, the SEV enum is being removed. Signed-off-by: Arvind Kumar <arvinkum@amd.com>
arvindskumar99
force-pushed
the
SEV-deprec
branch
from
aa6914e to
41f0923
Compare
@Xynnn007 Just rebased and pushed. |
5 participants
Rust requires all posibilities to be
exhausted when matching an enum, and
the Tee::SEV reference is being removed
in trustee/deps/verifier/src/lib.rs in
PR #984 in the trustee PR. So to avoid a
compilation error, the SEV enum is being
removed.