gha: SEV deprecation#984
Conversation
fitzthum
left a comment
fitzthum
left a comment
There was a problem hiding this comment.
We've never support SEV in Trustee anyway so fine to remove.
|
|
||
| pub fn to_verifier(tee: &Tee) -> Result<Box<dyn Verifier + Send + Sync>> { | ||
| match tee { | ||
| Tee::Sev => todo!(), |
There was a problem hiding this comment.
Rust will require all possibilities to be exhausted when matching enum, and sev is defined in kbs-types, so there will be a compilation error here. We need to delete this enum from the upstream, here
There was a problem hiding this comment.
@Xynnn007 I've opened a PR in kbs-types with this change: confidential-containers/kbs-types#78
There was a problem hiding this comment.
confidential-containers/kbs-types#78 has been merged.
There was a problem hiding this comment.
@Xynnn007 if everything else looks good, can you go ahead and approve the PR? Need one more green check before it can get merged.
There was a problem hiding this comment.
There are still CI errors. Please fix them and force push. Also you need to update the kbs-types version the the latest which does not include sev enum
ryansavino
left a comment
ryansavino
left a comment
There was a problem hiding this comment.
Need to make the change in kbs-types that @Xynnn007 mentioned. But otherwise LGTM, pending that change. @arvindskumar99 is opening that PR now.
Removing SEV references as a deprecation effort from all CoCo workflows. Signed-off-by: Arvind Kumar <arvinkum@amd.com>
arvindskumar99
force-pushed
the
SEV-deprec
branch
from
419217c to
c79bf16
Compare
|
@hgowda-amd would you be interested in inheriting this PR? |
yes, I would be. I ll take this up and finish up all the pending work on deprecating SEV workflows. |
…te SEV Move to pull ear crate from crates.io and bump kbs-types to v0.15.0 that uses the same ear version. kbs-types v0.15.0 also removes Sev TEE enum so the repository is adjusted accordingly. Original work was done in PR #984. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mythi <1049565+mythi@users.noreply.github.com> Co-authored-by: mkulke <273280+mkulke@users.noreply.github.com>
7 participants
Continuing the efforts from confidential-containers/guest-components#1117 to deprecate SEV workflows from CoCo.