Add generic emulator wrapper for NGJet#51267
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51267/49856 |
|
A new Pull Request was created by @Chriisbrown for CMSSW_17_0_X. It involves the following packages:
@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: RelVals Failed RelVals |
|
This PR needs to be tested with this cms-dist PR: cms-sw/cmsdist#10667 |
|
please test with cms-sw/cmsdist#10667 |
|
-1 Failed Tests: RelVals Failed RelVals |
|
hi @Chriisbrown thanks for this PR- looks like a |
|
Hi, I had forgotten to update the default model to v2_0_0 which is the one in the cms-dist update so it should work now |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51267/49895 |
|
Pull request #51267 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again. |
PR description:
This PR updates the Phase 2 L1TNGJet model wrapper to be more generic. Major changes include:
This PR needs to be merged alongside this cms-dist PR as it will cause bad any cast errors without this update
This PR does not change model performance, the cms-dist PR updates the emulator model wrapper only and not the model itself, outputs of the model are expected to remain constant
PR validation:
This PR is verified in this pipeline with specific plots measuring emulator / hls4ml matching here
Code check and formats are applied