Update L1TSC4NGJet model to v2.0.0#10667
Conversation
|
A new Pull Request was created by @Chriisbrown for branch IB/CMSSW_17_0_X/master. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e51e48/54113/summary.html Comparison SummarySummary:
|
|
assign l1 @cms-sw/l1-l2 any objections this update? |
|
New categories assigned: l1 @BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
+l1 |
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
@quinnanm @Chriisbrown , I guess this should also go in to 20.1.X ( current development IBs) .... right? |
Yes I believe it should, I targeted 17_0_X for this because of the corresponding 17_0_X PR in CMSSW |
This PR updates the L1NGJet Model cms-dist to the v2.0.0 tag which now includes the v2.0.0 model wrapper which makes the model emulator wrapper more generic allowing for different numbers of inputs being used in the NGJet model
This PR has a corresponding PR to CMSSW here
This PR does not change the model itself and only the wrapper, no changes are expected in the model output compared to the previous v1.0.1 model
The performance plots of this model are found here notable the emulator matching plots here