Skip to content

Update L1TSC4NGJet model to v2.0.0#10667

Merged
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_17_0_X/masterfrom
CMS-L1T-Jet-Tagging:IB/CMSSW_17_0_X/master
Jun 23, 2026
Merged

Update L1TSC4NGJet model to v2.0.0#10667
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_17_0_X/masterfrom
CMS-L1T-Jet-Tagging:IB/CMSSW_17_0_X/master

Conversation

@Chriisbrown

@Chriisbrown Chriisbrown commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR updates the L1NGJet Model cms-dist to the v2.0.0 tag which now includes the v2.0.0 model wrapper which makes the model emulator wrapper more generic allowing for different numbers of inputs being used in the NGJet model

This PR has a corresponding PR to CMSSW here

This PR does not change the model itself and only the wrapper, no changes are expected in the model output compared to the previous v1.0.1 model

The performance plots of this model are found here notable the emulator matching plots here

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Chriisbrown for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@smuzaffar

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e51e48/54113/summary.html
COMMIT: 0fa1981
CMSSW: CMSSW_17_0_X_2026-06-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10667/54113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 63
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337532
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

assign l1

@cms-sw/l1-l2 any objections this update?

@cmsbuild

Copy link
Copy Markdown
Contributor

New categories assigned: l1

@BenjaminRS,@quinnanm you have been requested to review this Pull request/Issue and eventually sign? Thanks

@quinnanm

Copy link
Copy Markdown
Contributor

+l1

@smuzaffar

Copy link
Copy Markdown
Contributor

+externals

@smuzaffar smuzaffar merged commit a866189 into cms-sw:IB/CMSSW_17_0_X/master Jun 23, 2026
8 checks passed
@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar

Copy link
Copy Markdown
Contributor

@quinnanm @Chriisbrown , I guess this should also go in to 20.1.X ( current development IBs) .... right?

@Chriisbrown

Copy link
Copy Markdown
Contributor Author

@quinnanm @Chriisbrown , I guess this should also go in to 20.1.X ( current development IBs) .... right?

Yes I believe it should, I targeted 17_0_X for this because of the corresponding 17_0_X PR in CMSSW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants