Split G4VG test into Gdml and Custom#40
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test suite by separating GDML loading tests from custom geometry builder tests into two distinct test files. The core functionality for testing has been extracted into a reusable TestBase class that both test suites inherit from.
Key Changes
- Created
TestBaseclass to provide common test infrastructure for geometry conversion validation - Split the original test file into
Gdml.test.ccfor GDML-based tests andCustom.test.ccfor custom geometry tests - Updated build system to compile separate test executables linked against a shared test library
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/TestBase.hh | Declares the new base test class with common test infrastructure |
| test/TestBase.cc | Implements shared test functionality extracted from the original test file |
| test/LoadGdml.hh | Removed file containing GDML loading utilities |
| test/Gdml.test.cc | GDML loading tests now use TestBase and inline the GDML loading logic |
| test/Custom.test.cc | New file containing custom geometry builder tests |
| test/CMakeLists.txt | Updated build configuration to create separate test executables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the GDML loading tests from the custom tests.