Skip to content

Split G4VG test into Gdml and Custom#40

Merged
sethrj merged 2 commits into
celeritas-project:mainfrom
sethrj:split-tests
Oct 22, 2025
Merged

Split G4VG test into Gdml and Custom#40
sethrj merged 2 commits into
celeritas-project:mainfrom
sethrj:split-tests

Conversation

@sethrj

@sethrj sethrj commented Oct 22, 2025

Copy link
Copy Markdown
Member

This separates the GDML loading tests from the custom tests.

@sethrj sethrj requested a review from Copilot October 22, 2025 18:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test suite by separating GDML loading tests from custom geometry builder tests into two distinct test files. The core functionality for testing has been extracted into a reusable TestBase class that both test suites inherit from.

Key Changes

  • Created TestBase class to provide common test infrastructure for geometry conversion validation
  • Split the original test file into Gdml.test.cc for GDML-based tests and Custom.test.cc for custom geometry tests
  • Updated build system to compile separate test executables linked against a shared test library

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/TestBase.hh Declares the new base test class with common test infrastructure
test/TestBase.cc Implements shared test functionality extracted from the original test file
test/LoadGdml.hh Removed file containing GDML loading utilities
test/Gdml.test.cc GDML loading tests now use TestBase and inline the GDML loading logic
test/Custom.test.cc New file containing custom geometry builder tests
test/CMakeLists.txt Updated build configuration to create separate test executables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/Gdml.test.cc Outdated
Comment thread test/Custom.test.cc Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sethrj sethrj enabled auto-merge (squash) October 22, 2025 18:29
@sethrj sethrj disabled auto-merge October 22, 2025 18:33
@sethrj sethrj merged commit 30f412b into celeritas-project:main Oct 22, 2025
3 checks passed
@sethrj sethrj deleted the split-tests branch October 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants