Skip to content

Add scan parameters to beacontool (Bugfix) #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xanthein wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add scan parameters to beacontool (Bugfix) #2521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d9f09b
Add scan_parameter to Beacontools
xanthein May 6, 2026
2fed4fd
Revert the eddystone_scanner workaround in #2475
xanthein May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions checkbox-support/checkbox_support/scripts/eddystone_scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@
BeaconScanner,
EddystoneURLFrame,
)
from checkbox_support.vendor.beacontools.const import (
BluetoothAddressType,
ScanFilter,
ScanType,
)
from checkbox_support.helpers.timeout import timeout
from checkbox_support.helpers.retry import retry
from checkbox_support.interactive_cmd import InteractiveCommand
Expand All @@ -37,11 +42,6 @@ def init_bluetooth():
with InteractiveCommand("bluetoothctl") as btctl:
btctl.writeline("power on")
time.sleep(3)
# workaround for some intel bluetooth controller
# if we don't enable scan on via bluetoothctl first,
# the hci 'advertising scan enable' command would failed
btctl.writeline("scan on")
time.sleep(3)
btctl.writeline("exit")
btctl.kill()

Expand All @@ -65,6 +65,13 @@ def callback(sub_event, bt_addr, rssi, packet, additional_info):
callback,
bt_device_id=hci_device,
packet_filter=EddystoneURLFrame,
scan_parameters={
"scan_type": ScanType.ACTIVE,
"interval_ms": 10,
"window_ms": 10,
"address_type": BluetoothAddressType.PUBLIC,
"filter_type": ScanFilter.ALL,
},
debug=debug,
)

Expand Down
3 changes: 1 addition & 2 deletions checkbox-support/checkbox_support/tests/test_eddystone_scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,5 @@ def test_initial_scripts(self, mock_command, mock_sleep):
eddystone_scanner.init_bluetooth()
mock_command.assert_called_with("bluetoothctl")
mock_btctl.writeline.assert_any_call("power on")
mock_btctl.writeline.assert_any_call("scan on")
mock_btctl.writeline.assert_any_call("exit")
self.assertEqual(mock_sleep.call_count, 2)
self.assertEqual(mock_sleep.call_count, 1)
Loading