Add scan parameters to beacontool (Bugfix)#2521
Open
xanthein wants to merge 2 commits into
Open
Conversation
Default address_type in set_scan_paramters is BluetoothAddressType.RANDOM which may cause issue if not set random address to Bluetooth controller in advance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
==========================================
- Coverage 58.92% 58.92% -0.01%
==========================================
Files 476 476
Lines 48033 48032 -1
Branches 8575 8575
==========================================
- Hits 28305 28304 -1
Misses 18835 18835
Partials 893 893
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hook25
requested changes
May 6, 2026
Hook25
left a comment
Hook25
left a comment
Collaborator
There was a problem hiding this comment.
Please improve the description explaining exactly why this is done this way because I can't quite understand. Also provide 4 submissions:
- Rpi3/4/5
- "prove" the fix worked on the original platform
Collaborator
|
Also, the issue is still present on UC18 (see #2466 (comment)). Hopefully this fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #2260, it remove the
blutoothctl scan on, and introduce issue #2466. In x86 enablement project also encounter similar issue SOMERVILLE-4545. From chip vendor's investigation, the root cause of this issue is scan with RANDOM address in scan parameter and not set the RANDOM address in advance, which had been addressed in BT specThis PR change the scan type to PUBLIC which don't need to set RANDOM address in advance. And can revert the workaround introduced by #2475.
Resolved issues
Fixes #2466
Documentation
Tests
Install checkbox-support from Test PPA and other checkbox packages from checkbox-beta. And run run test plan bluetooth-cert-automated on required machines