Skip to content

Create RVS snap common directory if it does not exist (BugFix) #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedro-avalos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create RVS snap common directory if it does not exist (BugFix) #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff4337
fix: create rvs snap common directory
pedro-avalos Apr 17, 2026
ca9ca52
fix: elevate user to root
pedro-avalos Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions providers/gpgpu/bin/rvs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def __init__(self, rvs: Path, config: Path) -> None:
# CHECKBOX-2021: Snap confinement prevents access to /usr/share

@ajzobro ajzobro Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still apply if it's run as root now?

@pedro-avalos pedro-avalos Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, snapd will still prevent the snap from accessing that directory

snap_bins = ["/snap/bin/rvs", "/snap/bin/rocm-validation-suite"]
if any(rvs.match(p) for p in snap_bins):
RVS_SNAP_COMMON.mkdir(parents=True, exist_ok=True)
shutil.copy(config, RVS_SNAP_COMMON)
self.config = RVS_SNAP_COMMON / config.name

Expand Down
1 change: 1 addition & 0 deletions providers/gpgpu/units/jobs.pxu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ _siblings: [
id: gpgpu/rvs-gpup
category_id: gpgpu
plugin: shell
user: root
estimated_duration: 4
requires:
graphics_card.vendor == 'Advanced Micro Devices, Inc. [AMD/ATI]'
Expand Down
Loading