Create RVS snap common directory if it does not exist (BugFix)#2481
Open
pedro-avalos wants to merge 2 commits into
Open
Create RVS snap common directory if it does not exist (BugFix)#2481pedro-avalos wants to merge 2 commits into
pedro-avalos wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
=======================================
Coverage 59.53% 59.53%
=======================================
Files 481 481
Lines 48579 48580 +1
Branches 8695 8695
=======================================
+ Hits 28922 28923 +1
Misses 18745 18745
Partials 912 912
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in a week. |
pedro-avalos
force-pushed
the
fix-rvs-missing-dir
branch
from
5714f89 to
ca9ca52
Compare
ajzobro
reviewed
Jun 17, 2026
| @@ -51,6 +51,7 @@ def __init__(self, rvs: Path, config: Path) -> None: | |||
| # CHECKBOX-2021: Snap confinement prevents access to /usr/share | |||
There was a problem hiding this comment.
Does this still apply if it's run as root now?
Collaborator
Author
There was a problem hiding this comment.
Yep, snapd will still prevent the snap from accessing that directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved issues
Documentation
Tests
https://certification.canonical.com/hardware/202606-38900/submission/494795/test-results/pass/