windows exe support#239
Merged
mdsteele merged 22 commits intoMay 30, 2026
Merged
Conversation
Contributor
philocalyst
commented
May 21, 2026
philocalyst
commented
- the cfg guards are a bit distasteful here
- involves a lot of (kind of) magic because assembling these is weirdly low-level
- includes some pleasant tests
- maybe an integration test or two would do good for us
- more or less full support
philocalyst
force-pushed
the
feature/windows-exe-bundle
branch
from
ea948fb to
91f91d0
Compare
philocalyst
force-pushed
the
feature/windows-exe-bundle
branch
from
ed1a132 to
6d4cd0d
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.