Brings in-line with cargo-cntp-bundler#232
Closed
philocalyst wants to merge 33 commits into
Closed
Conversation
Fixes the todo
to handle both it and dmg
philocalyst
force-pushed
the
contemporary-bundle
branch
from
87af047 to
726ed82
Compare
Contributor
Author
|
@mdsteele Any thoughts? |
Contributor
Author
|
@mdsteele @burtonageo Following up |
Collaborator
|
Hi, I apologize for sitting on this for so long. This PR is very large and seems to be doing several orthogonal things, which makes it harder to review thoroughly. It would be very helpful to split it up into several separate PRs, e.g. one to add the DMG support, one to add EXE support, one to add SVG support, etc. Overall, the features that this PR is seeking to add seem like good things to support. It's just harder to review them all at once. |
Contributor
Author
|
Got it! Will do @mdsteele |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happened to run into a project that had gone in a different direciton than cargo-bundle and wanted to get their changes into bundle! This is my attempt in that.
Huge credit to: https://github.com/vicr123/contemporary-rs/tree/master/deploy_tool
Most of this is directly ported, so not more battle tested or correct than the original implementation -- advice is very welcome.