Skip to content

osx maxxed out#237

Merged
mdsteele merged 14 commits into
burtonageo:masterfrom
philocalyst:feature/macos-osx-improvements
May 26, 2026
Merged

osx maxxed out#237
mdsteele merged 14 commits into
burtonageo:masterfrom
philocalyst:feature/macos-osx-improvements

Conversation

@philocalyst
Copy link
Copy Markdown
Contributor

@philocalyst philocalyst commented May 21, 2026 •
edited
Loading

  • There's some finer separating of concerns
  • There's a function for writing localizations in the format OSX expects!
  • Full DMG writing setup with UDZO images
  • Requires hdutil (this could maybe be done with a crate although I don't know if it's preferable)
  • Includes fairly basic testing

@philocalyst philocalyst force-pushed the feature/macos-osx-improvements branch from 75b167e to 78bfc6c Compare May 21, 2026 17:06
@philocalyst philocalyst changed the title osx localization! osx maxxed out May 21, 2026
This was referenced May 21, 2026
Merged
Closed
@philocalyst
Copy link
Copy Markdown
Contributor Author

philocalyst commented May 22, 2026

@mdsteele It would be nice if the CI clippy configuration was documented in a CONTRIBUTING.md or similar, because I didn't know what i was targeting. All mended, now.

mdsteele
mdsteele reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mdsteele mdsteele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable overall, just a few minor comments.

Comment thread Cargo.toml Outdated
Comment thread src/bundle/settings.rs
use super::PackageType;

// Each new short name should parse back to the correct variant.
assert_eq!(
Copy link
Copy Markdown
Collaborator

@mdsteele mdsteele May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be testing the other PackageTypes similarly?

Copy link
Copy Markdown
Contributor Author

@philocalyst philocalyst May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably... not, it's just a fluff test, I kind of wanted to just fold that into the display implementation rather than the .to_short_name helper, would that be okay?

Comment thread src/bundle/dmg_bundle.rs Outdated
Comment thread src/bundle/dmg_bundle.rs Outdated
@mdsteele
Copy link
Copy Markdown
Collaborator

mdsteele commented May 22, 2026

@mdsteele It would be nice if the CI clippy configuration was documented in a CONTRIBUTING.md or similar, because I didn't know what i was targeting. All mended, now.

Sorry about that. Happy to take a PR to document that better! (With whatever information would have been most helpful to you.)

@philocalyst philocalyst force-pushed the feature/macos-osx-improvements branch from 8ebc8de to bdeb334 Compare May 23, 2026 23:09
@mdsteele mdsteele merged commit a27e76e into burtonageo:master May 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdsteele mdsteele mdsteele left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philocalyst @mdsteele