Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion py/src/braintrust/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ def from_function_row(cls, row: dict[str, Any]) -> "RemoteEvalParameters":
)

def validate(self, data: Any) -> bool:
if not isinstance(data, Mapping):
return False
try:
validate_json_schema(data, self.schema)
return True
Expand Down Expand Up @@ -283,7 +285,7 @@ def _apply_defaults_to_json_schema_instance(instance: Any, schema: Mapping[str,
return instance


def validate_json_schema(parameters: dict[str, Any], schema: ParametersSchema) -> dict[str, Any]:
def validate_json_schema(parameters: Mapping[str, Any], schema: ParametersSchema) -> dict[str, Any]:
candidate = dict(parameters)
_apply_defaults_to_json_schema_instance(candidate, schema)

Expand Down
16 changes: 16 additions & 0 deletions py/src/braintrust/test_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,3 +674,19 @@ def schema(cls):
assert serialized["judge_model"]["type"] == "model"
for name in ("template", "main", "judge_model"):
assert "description" not in serialized[name]


@pytest.mark.parametrize("value", [None, 5, True, "", [], [["limit", 2]]])
def test_remote_parameters_validate_rejects_non_object_without_coercion(value):
parameters = RemoteEvalParameters(
id=None,
project_id=None,
name="test",
slug="test",
version=None,
schema={"type": "object", "properties": {"limit": {"type": "integer"}}},
data={},
)
assert parameters.validate(value) is False
assert parameters.validate({"limit": 2}) is True
assert parameters.validate({"limit": "wrong"}) is False