Repository navigation
Reject non-object inputs when validating saved evaluation parameters - #1147
Open
Gareth.Y (linjiaye929) wants to merge 1 commit into
Open
Gareth.Y (linjiaye929) wants to merge 1 commit into
Gareth.Y (linjiaye929) wants to merge 1 commit into
Conversation
Gareth.Y (linjiaye929)
marked this pull request as ready for review
November 19, 2026 04:20
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteEvalParameters.validate()is a boolean predicate for a parameter object, but its helper callsdict(data)before checking the JSON schema. For a schema with an optional integerlimit, this makes[["limit", 2]]validate as if it were{"limit": 2}. An empty array or empty string can also pass, whereasNone,Trueand integers can raiseTypeErrorinstead of returningFalse.Check for a mapping before normalizing the input; mappings still use the existing defaults and JSON Schema validation. The regression covers all six non-object inputs and valid and invalid object controls. No service, API key or model call is needed.
Verification on
4df5c78d(Linux):make fixup: all seven configured hooks passed.make -C py test-core(Python 3.14.7): 1,231 passed, 112 skipped, 12 expected failures; two pytest-asyncio deprecation warnings.This fix was prepared with AI assistance. Optional provider integration suites were not run; the change does not alter a provider integration.