Skip to content

make minimum and maximum optional for discovery autobins#706

Merged
gsfk merged 3 commits into
developfrom
feat/make-autobin-min-max-optional
Jun 15, 2026
Merged

make minimum and maximum optional for discovery autobins#706
gsfk merged 3 commits into
developfrom
feat/make-autobin-min-max-optional

Conversation

@gsfk

@gsfk gsfk commented Jun 11, 2026

Copy link
Copy Markdown
Member

Remove the requirements for minimum and maximum for automatically generated bins in discovery config. Requires bento_lib pr 343

The behaviour is unchanged:

  • values in the data that are less than minimum or greater than maximum are ignored (not counted in charts)
  • the leftmost bin is everything less than taper_left unless minimum = taper_left
  • the rightmost bin is everything greater than taper_right unless maximum = taper right

This matches the behaviour of so-called "manual" bins (where we consider the values for the left-most and right-most bins instead of "taper" values). It also allows for minimum and maximum to be used as meaningful limits in the search UI (rather than, e.g. having awkward hacks such as max age = 125 just so the bins will work)

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (38a8c06) to head (ac08d1c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #706   +/-   ##
========================================
  Coverage    95.59%   95.59%           
========================================
  Files          138      138           
  Lines         5805     5805           
  Branches       552      552           
========================================
  Hits          5549     5549           
  Misses         205      205           
  Partials        51       51           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gsfk gsfk requested a review from SanjeevLakhwani June 15, 2026 13:58

@SanjeevLakhwani SanjeevLakhwani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit de23adf into develop Jun 15, 2026
8 checks passed
@gsfk gsfk deleted the feat/make-autobin-min-max-optional branch June 15, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants