Make minimum and maximum optional for discovery autobins#343
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 82
Lines 2544 2544
Branches 234 234
=========================================
Hits 2544 2544
🚀 New features to boost your workflow:
|
gsfk
changed the title
davidlougheed
approved these changes
Jun 12, 2026
davidlougheed
left a comment
davidlougheed
left a comment
Member
There was a problem hiding this comment.
looks good based on the logic written in the docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the requirement for
minimumandmaximumvalues for discovery config "autobins". Required for katsu #706