fix(table-chart): fix "Search by" control visibility and improve table controls layout#36073
Conversation
Code Review Agent Run #1c82ecActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
i18n
dosubot
Bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing right margin in CSS refactor ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36073 +/- ##
==========================================
- Coverage 64.51% 64.51% -0.01%
==========================================
Files 2673 2673
Lines 147639 147640 +1
Branches 34093 34093
==========================================
- Hits 95252 95251 -1
- Misses 50655 50657 +2
Partials 1732 1732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the "Search by" control visibility logic in the Table chart and improves the layout of table controls. The key change corrects when the "Search by" dropdown appears - it now only shows when both "Server pagination" AND "Search box" options are enabled, rather than appearing with just "Server pagination" alone. Additionally, the PR enhances the visual consistency by moving control labels above their inputs and standardizing font sizes.
- Corrects "Search by" control visibility to require both server pagination and search box to be enabled
- Refactors control layouts to use vertical spacing with labels positioned above inputs
- Standardizes control sizing and font sizes for better visual consistency with table content
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| superset/translations/ru/LC_MESSAGES/messages.po | Updates Russian translations: removes plural forms for "%s record", adds translations for "Entries per page" and "Search by" |
| superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx | Removes tn import, updates SearchInput and SelectPageSize to use vertical layout, changes label text and removes placeholder |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx | Replaces styled component with inline CSS using theme tokens, adds size prop for consistency |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx | Adds translation function import and wraps "Search" text with t() for internationalization |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx | Implements fixed visibility logic for "Search by" control (requires both serverPagination and searchInput), adds vertical layout with label, and applies font size styling |
Comments suppressed due to low confidence (1)
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:228
- The placeholder attribute was removed from the Input component when the
tnfunction call was removed. This means users will see an empty input field with no hint about what to search for. Consider adding a placeholder using thet()function, for example:placeholder={t('Search...')}or similar text to provide a better user experience.
<Input
aria-label={t('Search %s records', count)}
value={value}
size="small"
onChange={onChange}
onBlur={onBlur}
ref={inputRef}
/>
SBIN2010
left a comment
SBIN2010
left a comment
There was a problem hiding this comment.
I left a couple of comments. But overall, it looks pretty good.
|
Looks like a couple failing tests, a conflict resolution needed, and a couple open comments on the thread, if you don't mind helping to get this through @innovark37. Thanks in advance! |
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai-for-open-source
Bot
added
the
size:M
Nitpicks 🔍
|
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
|
CodeAnt AI finished reviewing your PR. |
Code Review Agent Run #e3dd6fActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Looks like a merge conflict and some bot suggestions need addressing, if you don't mind :) |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #986dc8
Actionable Suggestions - 1
-
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx - 1
- Incorrect default operator · Line 44-44
Review Details
-
Files reviewed - 2 · Commit Range:
54398a6..e89f2d3- superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SearchSelectDropdown.tsx
- superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
|
@innovark37 the logic fix here looks good, and just needs a rebase (it's conflicting) and the open thread comments from @SBIN2010 addressed. Ping us when it's sorted, or say the word if you want help with the rebase. |
78ac913 to
0d51149
Compare
sfirke
left a comment
sfirke
left a comment
There was a problem hiding this comment.
Approving the translations piece
Code Review Agent Run #b6ae32Actionable Suggestions - 0Additional Suggestions - 1
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Thanks @innovark37, the visibility logic itself looks right. But the Also looks like @SBIN2010's note about dropping the record-count placeholder is still open... worth settling that before we re-review. Thanks! |
|
This PR is ready for review. The remaining test failures in |
Code Review Agent Run #db0051Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
SBIN2010
left a comment
SBIN2010
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution.
User description
SUMMARY
This PR addresses two main issues with the Table chart controls:
Layout Improvement: Enhances the visual layout of the "Entries per page", "Search by", and "Search" controls by moving labels above inputs and adjusting font sizes for better consistency with the table content.
Logic Fix: Corrects the display logic for the "Search by" control, which was previously shown incorrectly.
Now shows the control only when both "Server pagination" AND "Search box" options are enabled. Previously it appeared with only "Server Pagination" enabled, which was functionally incorrect.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CodeAnt-AI Description
Fix table search controls visibility and standardize table controls layout
What Changed
Impact
✅ Clearer search controls✅ Fewer misleading options shown✅ Consistent table control spacing and sizing💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.