test - #15290 - add test for compile static dynamic checking#15294
Closed
jdaugherty wants to merge 1 commit into
Closed
test - #15290 - add test for compile static dynamic checking#15294jdaugherty wants to merge 1 commit into
jdaugherty wants to merge 1 commit into
Conversation
Contributor
Author
|
Once groovy 4.0.30 is released we can update this pr to confirm it passes |
Contributor
Author
|
test for #15290 |
Contributor
Author
|
Note: the upstream groovy change was not backported to 4.0.30 so this will have to wait until Grails 8 / Groovy 5 |
Contributor
Author
|
FYI: #14088 |
jamesfredley
pushed a commit
that referenced
this pull request
May 20, 2026
Cherry-picks the `grails-test-examples/compile-static` project from #15294 (originally targeted at 7.0.x) onto grails8-groovy5-sb4. BookService calls Book.findAllByName('Joe') under @GrailsCompileStatic - the original GROOVY-11817 surface. On Groovy 5.0.6-SNAPSHOT the service compiles and BookServiceSpec passes without any reflection workaround: BookServiceSpec > test validateBooks method PASSED Conflict resolution notes: - Dropped the unrelated app1/grails-app/conf/application.groovy whitespace tweak (8.0.x already lacks the leading blank line). - Re-anchored the settings.gradle insert against 8.0.x's reordered Functional Tests include list (compile-static slots in alphabetically between cache and database-cleanup). Assisted-by: opencode:claude-4.7-opus
Contributor
|
Moved to #15557 |
jamesfredley
added a commit
that referenced
this pull request
May 20, 2026
Brings in from #15557: - The grails-test-examples/compile-static project (#15294 cherry-pick). - The 5.0.6-SNAPSHOT -> 5.0.6 pin in dependencies.gradle (conflict resolved in favour of this branch's 6.0.0-SNAPSHOT pin, since this canary tracks Groovy 6 not Groovy 5). Assisted-by: opencode:claude-4.7-opus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test to confirm fix for https://issues.apache.org/jira/browse/GROOVY-11817