fix: convert Title Case strings to sentence case in 02-strings.xml#21304
Open
Yousuf24100286 wants to merge 2 commits into
Open
fix: convert Title Case strings to sentence case in 02-strings.xml#21304Yousuf24100286 wants to merge 2 commits into
02-strings.xml#21304Yousuf24100286 wants to merge 2 commits into
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
|
Snapshot diff report vs
All 2 changed screenshotsAllActivitiesScreenshotTest
|
david-allison
left a comment
Member
There was a problem hiding this comment.
One change needed, rest looks great. Thanks!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Few (12 to be precise) of the strings in
02-strings.xmlremained. Converted them to string case and fixed the failing test for it.Fixes
Approach
How Has This Been Tested?
Ran build and test commands to test the changes. All passed.
Checklist
Please, go through these checks before submitting the PR.
Note: there wasn't much of a huge change to add comments.