Skip to content

fix: convert Title Case strings to sentence case in 02-strings.xml#21304

Open
Yousuf24100286 wants to merge 2 commits into
ankidroid:mainfrom
Yousuf24100286:fix/15760-sentence-case-02-strings
Open

fix: convert Title Case strings to sentence case in 02-strings.xml#21304
Yousuf24100286 wants to merge 2 commits into
ankidroid:mainfrom
Yousuf24100286:fix/15760-sentence-case-02-strings

Conversation

@Yousuf24100286

Copy link
Copy Markdown

Purpose / Description

Few (12 to be precise) of the strings in 02-strings.xml remained. Converted them to string case and fixed the failing test for it.

Fixes

Approach

  • Changed 12 Title Case strings to sentence case.
  • Fixed the failing test.

How Has This Been Tested?

Ran build and test commands to test the changes. All passed.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Note: there wasn't much of a huge change to add comments.

@github-actions

Copy link
Copy Markdown
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • AllActivitiesScreenshotTest: 2 changes
All 2 changed screenshots

AllActivitiesScreenshotTest

  • IntroductionActivity_compare.png
  • IntroductionActivity_edgeToEdge_compare.png

Comment thread AnkiDroid/src/test/java/com/ichi2/anki/TranslationTest.kt

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed, rest looks great. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Inconsistent String Casing

2 participants