Skip to content

fix: constructor typo and misleading tfidf count variable name #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: constructor typo and misleading tfidf count variable name #625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scispacy/candidate_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def __init__(
[ann_index, tfidf_vectorizer, ann_concept_aliases_list, kb]
):
raise ValueError(
"You cannot pass both a name argument and other constuctor arguments."
"You cannot pass both a name argument and other constructor arguments."
)

# Set the name to the default, after we have checked
Expand Down Expand Up @@ -466,11 +466,12 @@ def create_tfidf_ann_index(
empty_tfidfs_boolean_flags = numpy.array(
concept_alias_tfidfs.sum(axis=1) != 0
).reshape(-1)
number_of_non_empty_tfidfs = sum(empty_tfidfs_boolean_flags == False) # noqa: E712
# flags are True for non-empty vectors, so `== False` counts the empty ones.
number_of_empty_tfidfs = sum(empty_tfidfs_boolean_flags == False) # noqa: E712
total_number_of_tfidfs = numpy.size(concept_alias_tfidfs, 0)

print(
f"Deleting {number_of_non_empty_tfidfs}/{total_number_of_tfidfs} aliases because their tfidf is empty"
f"Deleting {number_of_empty_tfidfs}/{total_number_of_tfidfs} aliases because their tfidf is empty"
)
# remove empty tfidf vectors, otherwise nmslib will crash
concept_aliases = [
Expand Down