fix: constructor typo and misleading tfidf count variable name#625
Open
Chessing234 wants to merge 1 commit into
Open
fix: constructor typo and misleading tfidf count variable name#625Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Fix 'constuctor' -> 'constructor' in the CandidateGenerator error message (allenai#601) and rename number_of_non_empty_tfidfs to number_of_empty_tfidfs, which is what it actually counts (allenai#593). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two small correctness/clarity issues in
scispacy/candidate_generation.py:CandidateGeneratorerror message reads"...other constuctor arguments."—constuctoris a typo (fix: typo 'constuctor' → 'constructor' in CandidateGenerator error message #601).create_tfidf_ann_index()names the empty-vector countnumber_of_non_empty_tfidfs, butempty_tfidfs_boolean_flags == Falseselects the empty vectors. The printed message already treats it as the empty count, so only the variable name was wrong and misleading (fix: misleading variable name in create_tfidf_ann_index — number_of_non_empty_tfidfs counts empty vectors #593).Fix
constuctor→constructor.number_of_non_empty_tfidfs→number_of_empty_tfidfs(used in the print as well) and add a short comment clarifying the flag polarity.No behavioral change. Fixes #601, fixes #593.
Made with Cursor