Repository navigation
Conversation
make_query_type already defaults the query name, so the explicit QUERY_NAME attrs on mock nodes were redundant. The two things they actually pinned (query class name for predicate prefixes, table name for SQL) now travel explicitly: MockUser.query({"TABLE": "user"}, "UserQuery"). node.query() forwards both to make_query_type; bare .query() still caches by node.
Owner
Author
|
Superseded: this content is already on main (e56cfe6 and follow-ups) — main has since moved ahead (version 0.6, sqlmodel safe_rebuild). No unique commits remain on this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUERY_NAME has been unnecessary since make_query_type (5eeeacc) defaults the query class name. This removes the last two real uses (tests/mock_user.py):\n\n- Query class names (
UserQuery, matching predicate prefixes) now pass explicitly as the second arg to node.query().\n- Table mapping (user,review) travels in the namespace dict instead of falling out of name derivation.\n- BareNode.query()behavior unchanged (generated name, cached on the node).\n\n51 passed (full suite minus ladybug). No production code touched.