Repository navigation
Derive mock query names/tables; drop the Mock prefix - #17
Merged
Merged
Conversation
make_query_type already defaults the query name, so the explicit QUERY_NAME attrs on mock nodes were redundant. The two things they actually pinned (query class name for predicate prefixes, table name for SQL) now travel explicitly: MockUser.query({"TABLE": "user"}, "UserQuery"). node.query() forwards both to make_query_type; bare .query() still caches by node.
MockUser/MockReview -> User/Review. With QUERY_NAME gone, the Mock prefix was the only thing forcing explicit names and TABLE overrides: UserQuery = User.query() now derives the class name, predicate prefix and table (user) with nothing repeated. Same for Review. GraphQL subclasses updated to the new bases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16. The Mock prefix on fixture nodes was the only thing forcing explicit query names and TABLE overrides — the fixtures are users and reviews, so name them that way:
51 passed. Explicit TABLE/namespace stays for genuinely irregular mappings (legacy schemas) — the rule is now derive-by-default, override-when-necessary.