Repository navigation
test: mark the IBAN long-run timing test as a benchmark - #81
Merged
Merged
Conversation
test_matching_time_on_long_runs checks a 50 ms budget for the IBAN matcher and the regex PII redactor on 64k characters. On the macOS runner of the v0.13.1 admina-core release it measured 51.6 ms for the redactor on the "IT60 " run, and the publish job was skipped until the job was rerun. The test carries the benchmark marker, so CI (-m "not benchmark") leaves it out; the other tests of the file still run. The other tests with a time limit stay in CI: the pattern-pack and probe tests assert that a quadratic pattern goes over the budget, the linear probe measures about 0.6 ms against 50 ms, the Presidio test has a 5 s limit and the prescanned-tag test measures 2 to 77 ms against 0.5 s.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 50 ms budget of
tests/test_iban_it.py::test_matching_time_on_long_runson 64k characters failed on the macOS runner of the v0.13.1 admina-core release (51.6 ms for the redactor on the "IT60 " run); the publish job ran after a rerun. The test now carries thebenchmarkmarker, as the timing tests oftests/test_firewall_pattern_timing.pydo since 0.13.0.The other tests with a time limit were measured and stay in CI: the pattern-pack and probe tests assert that a quadratic pattern goes over the budget, the linear probe takes about 0.6 ms against 50 ms, the Presidio test has a 5 s limit and the prescanned-tag test takes 2 to 77 ms against 0.5 s.
Tests only; no release needed.