Skip to content

🧹 fix unused import warning for GenAIClient in frigate/genai/manager.py #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ManupaKDU wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

🧹 fix unused import warning for GenAIClient in frigate/genai/manager.py #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions frigate/genai/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
no chat feature is active) are never initialized.
"""

from __future__ import annotations

import logging
from typing import TYPE_CHECKING, Any, Optional

Expand All @@ -23,7 +25,7 @@ class GenAIClientManager:
def __init__(self, config: FrigateConfig) -> None:
self._configs: dict[str, GenAIConfig] = {}
self._role_map: dict[GenAIRoleEnum, str] = {}
self._clients: dict[str, "GenAIClient"] = {}
self._clients: dict[str, GenAIClient] = {}
self.update_config(config)

def update_config(self, config: FrigateConfig) -> None:
Expand Down Expand Up @@ -59,7 +61,7 @@ def update_config(self, config: FrigateConfig) -> None:
for role in genai_cfg.roles:
self._role_map[role] = name

def _get_client(self, name: str) -> "Optional[GenAIClient]":
def _get_client(self, name: str) -> Optional[GenAIClient]:
"""Return the client for *name*, creating it on first access."""
if name in self._clients:
return self._clients[name]
Expand All @@ -78,7 +80,7 @@ def _get_client(self, name: str) -> "Optional[GenAIClient]":
return None

try:
client: "GenAIClient" = provider_cls(genai_cfg)
client: GenAIClient = provider_cls(genai_cfg)
except Exception as e:
logger.exception(
"Failed to create GenAI client for provider %s: %s",
Expand All @@ -91,19 +93,19 @@ def _get_client(self, name: str) -> "Optional[GenAIClient]":
return client

@property
def chat_client(self) -> "Optional[GenAIClient]":
def chat_client(self) -> Optional[GenAIClient]:
"""Client configured for the chat role (e.g. chat with function calling)."""
name = self._role_map.get(GenAIRoleEnum.chat)
return self._get_client(name) if name else None

@property
def description_client(self) -> "Optional[GenAIClient]":
def description_client(self) -> Optional[GenAIClient]:
"""Client configured for the descriptions role (e.g. review descriptions, object descriptions)."""
name = self._role_map.get(GenAIRoleEnum.descriptions)
return self._get_client(name) if name else None

@property
def embeddings_client(self) -> "Optional[GenAIClient]":
def embeddings_client(self) -> Optional[GenAIClient]:
"""Client configured for the embeddings role."""
name = self._role_map.get(GenAIRoleEnum.embeddings)
return self._get_client(name) if name else None
Expand Down
Loading