🧹 fix unused import warning for GenAIClient in frigate/genai/manager.py#59
🧹 fix unused import warning for GenAIClient in frigate/genai/manager.py#59ManupaKDU wants to merge 1 commit into
Conversation
…used import warning The linter flagged `GenAIClient` as an unused import because it was only referenced inside string literals (`"GenAIClient"`) for forward referencing in type hints. Instead of removing the import and substituting it with `Any`, this adds `from __future__ import annotations` and removes the string quotes from the type hints. This resolves the linter warning by directly associating the imported symbol with the types, while fully preserving strict typing and the benefits of lazily evaluating `GenAIClient` via `TYPE_CHECKING` to prevent circular imports. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation failedThis PR was automatically closed because the description does not follow the pull request template. Issues found:
Please update your PR description to include all required sections from the template, then reopen this PR.
|
1 participant
🎯 What: Fixed an unused import warning for
GenAIClientinfrigate/genai/manager.py.💡 Why: The import was only used inside string literals for type hinting, making it appear unused to linters and static analysis. It's important to maintain these type hints without introducing circular imports or silencing valid typing constraints. Using
from __future__ import annotationssolves both issues while improving code maintainability.✅ Verification: Verified that
ruff checkno longer raises an unused import warning and thatmypypasses cleanly with the unquoted strict type references. Cleaned up scratchpad files.✨ Result: A more readable file that passes linter checks while preserving exact type information.
PR created automatically by Jules for task 31685012239192026 started by @manupawickramasinghe