Skip to content

Improve handling of the "modded version" in TitleScreen #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gniftygnome merged 1 commit into from
Jun 13, 2026
+5 −5
Merged

Improve handling of the "modded version" in TitleScreen #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/com/terraformersmc/modmenu/mixin/MixinTitleScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ private void addModMenuIconWidget(CallbackInfo ci, @Local(name = "currentButton"
));
}

@ModifyArg(method = "extractRenderState", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/GuiGraphicsExtractor;text(Lnet/minecraft/client/gui/Font;Ljava/lang/String;III)V", ordinal = 0))
private String onRender(String string) {
@WrapOperation(method = "extractRenderState", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/resources/language/I18n;get(Ljava/lang/String;[Ljava/lang/Object;)Ljava/lang/String;"))
String modifyModdedVersionString(String id, Object[] args, Operation<String> original) {
if (ModMenuConfig.MODIFY_TITLE_SCREEN.getValue() && ModMenuConfig.MOD_COUNT_LOCATION.getValue().isOnTitleScreen()) {
String count = ModMenu.getDisplayedModCount();
String specificKey = "modmenu.mods." + count;
Expand All @@ -92,9 +92,9 @@ private String onRender(String string) {
replacementKey = specificKey + ".secret";
}

return string.replace(I18n.get(I18n.get("menu.modded")), I18n.get(replacementKey, count));
} else {
return string;
return I18n.get(replacementKey, count);
}

return original.call(id, args);
}
}
Loading