Skip to content

Improve handling of the "modded version" in TitleScreen#1033

Merged
gniftygnome merged 1 commit into
TerraformersMC:26.2from
litetex:improve-modded-version-string-on-title-screen
Jun 13, 2026
Merged

Improve handling of the "modded version" in TitleScreen#1033
gniftygnome merged 1 commit into
TerraformersMC:26.2from
litetex:improve-modded-version-string-on-title-screen

Conversation

@litetex

@litetex litetex commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The existing code had the following problems:

  1. It used String replace instead of simply supplying the correct value
  2. I18n.get was called twice

@gniftygnome

Copy link
Copy Markdown
Contributor

It's a kind of horrible mixin and I admit I haven't bothered fully understanding this change, but the title screen looks the same before and after, which I assume is the expected result (in en_us anyway).

@gniftygnome gniftygnome merged commit 09da617 into TerraformersMC:26.2 Jun 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants