Repository navigation
Show the player's own home: one still per housing rung - #236
Merged
Merged
Conversation
…025) Home showed the same rented room whatever the player lived in, so buying up the housing ladder never changed the picture. Home now has one still per rung with a roof - the rented room over the tavern, the driftwood shack on the shingle, the cozy cottage, the sturdy cabin and the waterfront manor on the harbour wall - each bigger, better built and better furnished than the last, with more fishing gear on show. - art/gen_homes.py writes the five scenes (art/home-*.scene); a test fails if a committed scene is stale. Rendered with art/render.py at Strata v0.6.0, twice, byte-identical. The single home still is gone. - src/stills/stills.py picks the key by rung, in HOUSING_TIERS order (HOME_STILLS); the homeless rung still shows no picture. Only player.homeTier is read - no change to saves. - Tests: every rung maps to an existing still and PNG, rung names are pinned so a renamed tier fails, a move shows on the next visit home, homeless shows none; the bundle and the docker CI job check every still the manifest names. - pictures/: 384,268 of 524,288 bytes. README and the contact sheet updated, plus docs/images/stills/homes.png. All provisional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S6kaEL7kt5Fverjb6didBH
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home showed the same rented room whatever the player lived in, so buying up the housing ladder never changed the picture. Home now shows the player's own home: one still per rung of the housing ladder that has a roof, each bigger, better built and better furnished than the last, with the fishing gear growing with it.
home-rentedhome-shackhome-cottagehome-cabinhome-manorCode.
src/stills/stills.pypicks the key by rung, inhousing.HOUSING_TIERSorder (HOME_STILLS), not by tier name. The test pins each rung's name to its still, so a renamed, added or reordered rung fails the test instead of showing the wrong house. Onlyplayer.homeTieris read, so the save format, reader and writer are not changed.Art.
art/gen_homes.pywritesart/home-*.scene, and a test fails if a committed scene is stale. The stills were rendered withart/render.pyand the Strata v0.6.0strata-golden(headless llvmpipe), then rendered a second time to confirm the output is byte-identical. The singlehomestill andart/home.scenewere removed.pictures/now uses 384,268 of 524,288 bytes. Everything is still marked provisional inart/stills.json, alt text included.Tests.
home-rentedandhome-manor../test.shpasses locally (1060 tests). The README was updated,docs/images/stills/contact-sheet.pngwas regenerated with all nine stills, anddocs/images/stills/homes.pngwas added.🤖 Generated with Claude Code
https://claude.ai/code/session_01S6kaEL7kt5Fverjb6didBH
drafted by Claude on behalf of Daniel Stephenson