Repository navigation
Cover the operator chip, a stale highlight and an unnamed sick hand - #239
Merged
dmccoystephenson merged 1 commit intoOct 28, 2026
Merged
Conversation
Three reachable branches had no test: the [OPERATOR MODE] header chip, the pygame highlight stepping in from the nearest end when it sits on a row that has gone grey, and pressing on through sickness with a crew of unnamed hands. Each is pinned as it behaves today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (one pass, scored against the diff and CI run 40651081053):
Judgment notes:
All items pass or are not applicable. The PR is ready to merge: test-only, with no do-not-auto-merge path touched. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
test/operator-chip-stale-highlight-unnamed-sick-hand
branch
October 28, 2026 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle. Three reachable, behaviour-bearing branches were found uncovered and are now pinned as they behave today. No production code is changed.
src/ui/baseUserInterface.py:63: the[OPERATOR MODE]header chip and itsoperatorclass are asserted intests/ui/test_webUserInterface.py, alongside the existing energy-chip test.src/ui/pygameUserInterface.py:184: a highlight left on a row that has since gone grey is shown to step in from the nearest end (DOWN lands on the first selectable row, UP on the last). The test is intests/ui/test_pygameUserInterface.py.src/business/adventures.py:280: pressing on through sickness with a crew of unnamed hands is shown to take one off the headcount and to report "a hand" rather than a name. The roll is patched to0.0. The test is intests/business/test_adventures.py.Coverage of
srcwent from 16 missed lines to 13. The lines still missed are the ones already recorded as unreachable guards, the__main__block, vendored client code or the protectedsaveFileManager.py.Before this work was picked, a Stage A documentation sweep was run on what changed since the last one (the location stills from #235 and #236). The README's stills section was checked against
src/stills/stills.py,art/stills.json,art/render.py,tests/stills/test_stills.pyand tak's picture support in each front-end. PLANNING.md and the Python versions in the Dockerfile and both workflows were also checked. No drift was found, so no docs change is included.No tracking issue: the gap was found during triage, with the issue backlog empty.
Test plan
black --checkon the three changed test files.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson