Skip to content

Fixes make clean on MacOS #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirkmueller merged 1 commit into from
Jun 16, 2026
Merged

Fixes make clean on MacOS #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ endif
.PHONY: clean
clean:
@rm -rfv $(BUILD_DIR)
@find . -type f -executable -name '*.test' -exec rm -f {} \+
@find . -type f -name '*.test' -exec test -x {} \; -exec rm -f {} \+

@dirkmueller dirkmueller Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think practically you could also do -perm /100 instead of -executable, avoids the -exec test call. yes, tehre is a small difference (one just checks unix permissions, the other one also ACLs) but that's not something we actually have.


.PHONY: lint
lint:
Expand Down
Loading