Fixes make clean on MacOS#494
Merged
Merged
Conversation
dirkmueller
reviewed
Jun 12, 2026
| clean: | ||
| @rm -rfv $(BUILD_DIR) | ||
| @find . -type f -executable -name '*.test' -exec rm -f {} \+ | ||
| @find . -type f -name '*.test' -exec test -x {} \; -exec rm -f {} \+ |
Member
There was a problem hiding this comment.
I think practically you could also do -perm /100 instead of -executable, avoids the -exec test call. yes, tehre is a small difference (one just checks unix permissions, the other one also ACLs) but that's not something we actually have.
dirkmueller
approved these changes
Jun 12, 2026
frelon
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a very simple issue when building the
elemental3andelemental3ctlbinaries on macOS, where callingmake cleanresults in an error:The problem is that the
Makefileexpects to be using a Linux-basedfindutility, where the-executableswitch works just fine, but this is not available on macOS. Here's the original line:A simple fix here is to introduce a new check as part of the
findcall, where it actually usestestto see if each file it encounters is executable, and if so, then pass it over torm -f. This bypasses the OS-specific parameter entirely.Testing of this patch, firstly on Linux:
Then on macOS:
Fixes: #493